Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hash dict in CI #1450

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Don't hash dict in CI #1450

merged 1 commit into from
Mar 3, 2023

Conversation

abejgonzalez
Copy link
Contributor

This should fix the https://github.com/firesim/firesim/actions/runs/4320725928 issues.

Related PRs / Issues

UI / API Impact

Verilog / AGFI Compatibility

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@abejgonzalez abejgonzalez requested a review from t14916 March 3, 2023 06:15
Copy link
Contributor

@t14916 t14916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although maybe the typing should me made clearer in platform lib to prevent issues like this?

@abejgonzalez
Copy link
Contributor Author

LGTM, although maybe the typing should me made clearer in platform lib to prevent issues like this?

The platform lib is returning the right type its just the set(dict(...)) that is causing issues. Frankly I'm not sure why mypy isn't catching it but I'll leave that for later.

I'll go ahead and merge this PR since the CI doesn't check it.

@abejgonzalez abejgonzalez merged commit d8aed54 into main Mar 3, 2023
@abejgonzalez abejgonzalez deleted the fix-cleanup branch March 3, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants