-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FireMarshal for Prototype Platform #190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me in general, just some minor comments.
I'll trust you to have tested it sufficiently. Have you run firemarshal/scripts/fullTest.py with the different board configured? I suppose it should work but it's worth checking.
I think most of it should work... but I'm not sure if you have tests that need the block/NIC modules. I'll do more thorough testing before it gets merged. |
I think there are one or two tests that rely on the drivers. The test script will run all tests and report which ones failed so we can double check that it's only those that we expect to fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
As an FYI, Im getting alot of failures running the regressions suite that seem to point to BWRC issues rather than issues with the workload. I've gone ahead and tested the following on the VCU118 prototype platform:
I'll run the test suite on an EC2 machine later to see if I can get things to work better. |
I don't think running the test suite is good right now mainly because the prototype platform doesn't include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. All tests passed on firechip board.
This is the initial work to get FireMarshal working for the prototype platform (specifically the VCU118). This adds a new "board" called
prototype
and a new "simple" configuration calledbr-chip-base.json
.This works with GPIOs, SDCard.
TODO:
install
functionality to run thechange-addresses
on the output of thebuild
modprobe
failing since there are no Linux modules on the prototype (fails in theinit
script when loading FireMarshal modules and in the default init script)./scripts/fullTest.py
)