Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FireMarshal for Prototype Platform #190

Merged
merged 8 commits into from
Apr 6, 2021
Merged

FireMarshal for Prototype Platform #190

merged 8 commits into from
Apr 6, 2021

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Apr 2, 2021

This is the initial work to get FireMarshal working for the prototype platform (specifically the VCU118). This adds a new "board" called prototype and a new "simple" configuration called br-chip-base.json.

This works with GPIOs, SDCard.

TODO:

  • Add install functionality to run the change-addresses on the output of the build
  • Clean up the Linux and Busybox configs more
  • Fix the modprobe failing since there are no Linux modules on the prototype (fails in the init script when loading FireMarshal modules and in the default init script)
  • Expect FireMarshal test output (from ./scripts/fullTest.py)

Copy link
Contributor

@NathanTP NathanTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me in general, just some minor comments.

I'll trust you to have tested it sufficiently. Have you run firemarshal/scripts/fullTest.py with the different board configured? I suppose it should work but it's worth checking.

boards/prototype/base-workloads/br-chip-base.json Outdated Show resolved Hide resolved
boards/prototype/base-workloads/br-chip-base/linux-config Outdated Show resolved Hide resolved
@abejgonzalez
Copy link
Contributor Author

This looks good to me in general, just some minor comments.

I'll trust you to have tested it sufficiently. Have you run firemarshal/scripts/fullTest.py with the different board configured? I suppose it should work but it's worth checking.

I think most of it should work... but I'm not sure if you have tests that need the block/NIC modules. I'll do more thorough testing before it gets merged.

@NathanTP
Copy link
Contributor

NathanTP commented Apr 2, 2021

I think there are one or two tests that rely on the drivers. The test script will run all tests and report which ones failed so we can double check that it's only those that we expect to fail.

NathanTP
NathanTP previously approved these changes Apr 2, 2021
Copy link
Contributor

@NathanTP NathanTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abejgonzalez
Copy link
Contributor Author

As an FYI, Im getting alot of failures running the regressions suite that seem to point to BWRC issues rather than issues with the workload. I've gone ahead and tested the following on the VCU118 prototype platform:

./marshal -v -d build br-base.json with BBL and OpenSBI
and
./marshal -v -d install -t prototype br-base.json

I'll run the test suite on an EC2 machine later to see if I can get things to work better.

@abejgonzalez
Copy link
Contributor Author

I don't think running the test suite is good right now mainly because the prototype platform doesn't include bash which nullifies most if not all of the tests (things hang since the scripts can't be run). I fixed some other small issues but this should be good to go now if you don't mind running the test suite fully.

Copy link
Contributor

@NathanTP NathanTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. All tests passed on firechip board.

@abejgonzalez abejgonzalez merged commit 8d9f718 into dev Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants