Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Devtools still active in a production build. #3

Closed
crucialfelix opened this issue Jun 22, 2016 · 2 comments
Closed

React Devtools still active in a production build. #3

crucialfelix opened this issue Jun 22, 2016 · 2 comments
Assignees
Labels

Comments

@crucialfelix
Copy link

crucialfelix commented Jun 22, 2016

Thanks for the package, I find it essential for development !

I am using electron-prebuilt 1.2.3. Maybe I can move to the upstream react-devtools now ?

The problem:

For some reason when I make a production release, electron-react-devtools is still activating and there is still a React tab.

But it fails and throws an error because the devDependencies are not included with the production build and so react-developer-tools fails to import portfinder.

module.js:440 Uncaught Error: Cannot find module 'portfinder'

This is somehow being injected by electron-react-devtools, but to be honest I can't understand why.

screen shot 2016-06-22 at 17 32 57

I installed as per instructions with require('electron-react-devtools').install();

Where did it install to ? How do I uninstall it ? I flushed the electron-prebuilt dist cache, but it is still there.

I do NOT do this anymore:

// in development.
  if (process.env.NODE_ENV !== 'production') {
    require('electron-react-devtools').inject()
  }

as I am on 1.2.3. So I am not even requireing it at all and definitely not injecting.

Thank you for your help !

@crucialfelix
Copy link
Author

I think I found it: /Users/crucial/Library/Application Support/PlaySPLOM/

This is for the Electron app I am working on.

There is a Preferences file in there and in some applications there is also a DevTools Extensions

That is perhaps how it kept injecting itself.

Even though I removed electron-react-devtools from devDependencies, it would still somehow activate. I finally had to also remove the source from node_modules.

@firejune firejune added the bug label Aug 16, 2016
@firejune firejune self-assigned this Aug 16, 2016
firejune added a commit that referenced this issue Aug 16, 2016
@firejune
Copy link
Owner

Resolved, please update version to 0.4.0

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants