Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Abstract.php #364

Closed
wants to merge 1 commit into from

Conversation

michaelhettwer
Copy link

Fix problem with duplicate header lines -> Mass Printing PDF
SolutioN: Empty array after generating each header

Fix problem with duplicate header lines -> Mass Printing PDF
@Schrank
Copy link
Member

Schrank commented Nov 22, 2017

Thanks for your PR! May you please add a PDF/Screenshot or steps how to reproduce the problem? I don't understand what you want to fix :-)

@michaelhettwer
Copy link
Author

Hey Fabian

after selecting more than one invoices and select print invoices the generated pdf files includes duplicate header lines.

Invoice-Nr, Customer Nr and Vat ID are included in the first pdf: 1 time
in the second: 2 times
in the third: 3 times

after empty the array the issue is fixed :-)

best

michael

@sprankhub
Copy link
Member

Thanks.

_headerLines is an array. You set it to an empty string. It should probably be set to array().

@michaelhettwer
Copy link
Author

Of course, it should be. Thanks ;-)

@Schrank
Copy link
Member

Schrank commented Nov 22, 2017

Thanks, I'll fix that. But I prefer to reset the headerLines on loop start :-)

@Schrank Schrank closed this Nov 22, 2017
@michaelhettwer
Copy link
Author

Yeah, of course. Array() and on Loop start. Sorry for quick dirt fixing ;-)

@Schrank
Copy link
Member

Schrank commented Nov 22, 2017

Thanks for bringing it up! <3

Schrank added a commit that referenced this pull request Nov 22, 2017
Thanks @michael-hxx!

#364
@Schrank Schrank mentioned this pull request Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants