Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enableCRAWorkaround configuration property #216

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Conversation

hbenl
Copy link
Collaborator

@hbenl hbenl commented Jun 26, 2020

Workaround for facebook/create-react-app#6074: Adding/removing breakpoints doesn't work for sources that were changed after the dev-server was started.

Copy link
Member

@juliandescottes juliandescottes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Not completely clear if this is also an issue with the builtin devtools. I'll try to repro and file a bug for DevTools.

@hbenl
Copy link
Collaborator Author

hbenl commented Aug 21, 2020

@juliandescottes If I remember correctly, this was not an issue in the Firefox devtools, because they ignore the HMR updates and in this case that's the right thing to do.

@hbenl hbenl merged commit 27dc007 into master Aug 21, 2020
@hbenl hbenl deleted the cra-workaround branch August 21, 2020 08:08
@juliandescottes
Copy link
Member

Oh right, when I read the comment facebook/create-react-app#6074 (comment) I assumed it was now also broken with FF, but that probably meant vscode + FF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants