This repository has been archived by the owner on May 2, 2018. It is now read-only.
fix #58 - disable eslint strict rule in load-reps.js #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchevobbe
approved these changes
Jan 30, 2017
|
Thanks for the review Nicolas! |
|
Sure : Don't hesitate to put me as a reviewer on PR so I know I can merge them if they look good to me :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can either disable as proposed here or modify the copy-assets script to add "use strict" dynamically in load-reps.
This PR also adds a "use strict" in test head file.
Weirdly eslint src/**/*.js ignores files in src/test/ . See eslint/eslint#1663 (comment)
I don't want to "fix" this here because head.js is full of eslint errors when checked against this repo's rules.
A more robust eslint approach here would be to have all files supposed to be copied to mc in a subfolder, with a dedicated .eslint rc that could set the env (and certain rules) to be inline with mc.