Infer some categories on old processed profiles based on function names #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can do this to processed profiles because those are already symbolicated.
Codecov Report
@@ Coverage Diff @@
## master #1248 +/- ##
=========================================
+ Coverage 77.55% 77.6% +0.05%
=========================================
Files 150 150
Lines 9859 9888 +29
Branches 2416 2419 +3
=========================================
+ Hits 7646 7674 +28
- Misses 1992 1993 +1
Partials 221 221
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work extracted from Markus' thread activity graphs PR #1072.
It contains the following 3 commits, plus one more from me adding a few comments and types.