This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Re-write getting started docs #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonLaster
commented
Nov 28, 2016
|
|
||
| **Share what you know** Give a talk in school, work, or a local meetup. I'm willing to bet your audience will not know the debugger is a web app! | ||
|
|
||
| - here are @amitzur's [slides](https://docs.google.com/presentation/d/1jdnvL-BwwxEuFbb9tiRxcT6UT-Ua0jGhy9FKBT4b43E/edit) from his [talk](https://twitter.com/amitzur/status/790153843946426369) |
There was a problem hiding this comment.
@clarkbw i think your slides could be good here too
|
|
||
| ```bash | ||
| yarn run chrome | ||
| ``` |
There was a problem hiding this comment.
🌟 @Garbee I think you'll like this!
| * [linux](https://github.com/devtools-html/debugger.html/issues/1082) | ||
|
|
||
|
|
||
| ``` |
There was a problem hiding this comment.
ughh, meant to have some context here. not sure if we need the same linux details
clarkbw
approved these changes
Nov 28, 2016
| @@ -1,6 +1,6 @@ | |||
| # debugger.html | |||
| # Debugger.html | |||
There was a problem hiding this comment.
Why the caps? We've always gone lowercase.
There was a problem hiding this comment.
haha - yeah, wanted to have a conversation about and hear why. sorry forgot to comment
| @@ -0,0 +1,22 @@ | |||
| const spawn = require('child_process').spawn; | |||
|
|
|||
| const chromeBinary = "/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome" | |||
There was a problem hiding this comment.
Maybe a note or file a followup issue to get Windows working.
|
|
||
| ```bash | ||
| npm i -g [email protected] | ||
| g clone [email protected]:devtools-html/debugger.html.git |
|
|
||
| #### Starting Firefox | ||
|
|
||
| If you're looking for an alternative to `yarn run firefox`, you have two options: cli, gcli. |
There was a problem hiding this comment.
I think you might have skipped the GCLI option below.
jasonLaster
force-pushed
the
docs-getting-started
branch
from
3128e10 to
6a3b393
Compare
jasonLaster
commented
Nov 29, 2016
| @@ -35,126 +25,19 @@ We respect your time and want to help you make the most of it as you learn more | |||
| * [Configuration](#configuration) | |||
| * [Create a local config file](#create-a-local-config-file) | |||
| * [Issues and Pull Request labels](#issues-and-pull-requests) | |||
| [Project Overview](#sd) | |||
| [What should I know before I get started?](#what-should-i-know-before-i-get-started) | |||
jasonLaster
force-pushed
the
docs-getting-started
branch
11 times, most recently
from
91d6c07 to
178a666
Compare
1. add getting started 2. add first activity 3. consolidate contributing 4. consolidate readme
jasonLaster
force-pushed
the
docs-getting-started
branch
from
178a666 to
c69b36c
Compare
This was referenced Nov 29, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue: #1233
Overview
We've gotten lots of feedback on our getting started docs. Here are some takeaways
Summary of Changes
Test Plan
CC @Garbee, @clarkbw, @viswanathamsantosh