Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Allow user to provide location when starting Firefox. #1201

Merged
merged 1 commit into from
Nov 15, 2016

Conversation

Garbee
Copy link
Contributor

@Garbee Garbee commented Nov 15, 2016

Associated Issue: No direct issue. Precursor to simplifying the getting started flow brought up in issue #1127.

Summary of Changes

Firefox startup bin now takes an optional location parameter. If not provided, it defaults to about:blank as that is safe for a fast startup for a developer to use it. We also know that exists always, so it won't cause the terminal to dump out needlessly.

Testing

  • passes npm test
  • passes npm run lint

Copy link
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

nice use of url.parse, url.format.

This solves the problem where a user does:

npm run firefox
npm start

and is surprised that firefox opens to an error page and is not connected with the debugger.

The reason it failed was that previously it was trying to go to todomvc, which was an examples' server route and the server had not yet started.

@jasonLaster jasonLaster merged commit 66a809e into firefox-devtools:master Nov 15, 2016
@Garbee Garbee deleted the garbee/ff-no-error branch December 15, 2016 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants