Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Updated #26

Open
wants to merge 9 commits into
base: gh-pages
Choose a base branch
from
Open

Conversation

chocos10
Copy link

@chocos10 chocos10 commented Oct 21, 2017

referenced to #14

@tsl143
Copy link
Member

tsl143 commented Oct 28, 2017

@chocos10 , thanks for taking this.
This looks good, but breaks in responsive design.
screen shot 2017-10-28 at 10 35 48 am

style.css Outdated

#logo img {
height: 100px;
float: left;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try flex-box, instead of floats. This will help you deal with mobile layout too.

style.css Outdated
margin-top: -60px;
}
h1{
font-family: 'Concert One', cursive;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stick to zilla fonts as mentioned in style guide lines (mozilla.ninja)

style.css Outdated
}

#logo img {
height: 100px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image included is 48px and is stretched to 100px so it looks blurred.

@chocos10
Copy link
Author

@tsl143 will change this thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants