PWA webmanifest missing from select pages

[brianramseyau]

Support guidelines

• I've read the support guidelines

I've found a bug and checked that ...

• ... the documentation does not mention anything about my problem
• ... there are no open or closed issues that are related to my problem
• ... it's definitely a Firefly III issue, not me

Description

I have noticed that some (perhaps newer?) pages do not include the webmanifest for PWA support.

These include pages such as Login and Dashboard (which, are kind of the most important to have this present IMO). Other pages such as Bills or Budget present the manifest just fine.

This is potentially just an oversight of a/the (new?) templating system where it doesn't have the include such is present in

firefly-iii/resources/views/partials/favicons.twig

Line 4 in ec59f80

<link rel="manifest" href="manifest.webmanifest?v=3e8AboOwbd">

Potentially splitting the manifest link tag into a separate partial and including it in the PWA template also (https://github.com/firefly-iii/firefly-iii/blob/ec59f80fe3c18d408382e4916dec9d95eb45b556/resources/views/pwa.twig)? or further down the chain in the system itself...

Debug information

Present up to and including v6.1.7

Expected behaviour

PWA manifest to be presented with all pages, including login and dashboard.

Steps to reproduce

No response

Additional info

No response

[JC5]

The webmanifest is present on the dashboard. This is easy to verify on the demo site. What makes you think it isn't?

The fact that it's not present on the login and register pages is correct, and that's easily fixable.

[brianramseyau]

Thanks for the prompt reply @JC5

The Demo site appears to be on the V1 dashboard, not the V2 one... this is why, I expect, it's not aligned with my V2 findings.
While I understand V2 is a WIP, this is, I feel a valid point to raise (early)

I also understand I missed this vital piece of information in my original report, and I apologise

[brianramseyau]

This is a screenshot of the network loaded assets on the v2 dashboard on my instance, for context

[github-actions]

Hi there!

This is an automatic reply. Share and enjoy

It seems your issue is about the new v2-layout that is currently in development for Firefly III.

These issues are collected in a GitHub discussion.

Please note that the v2 layout is still very much in development.

Thank you for your contributions.