Improve clarity of SWSaturationAdjustment class #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functions in SWSaturationAdjustment align
tommbendall
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests makes some improvements to the layout of the SWSaturationAdjustment class. It clarifies the order of the source terms and the test functions as
water_vapour,cloud_water, (D), (b), whereDis added for convective feedback andbfor thermal feedback. This alignment between the order of source terms and test functions ensures that the correct terms are added to the residual. This pull request does not change what happens in the code but changes the layout slightly and adds some comments with the aim of making this clear.