Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique physics labels #442

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Unique physics labels #442

merged 3 commits into from
Sep 26, 2023

Conversation

tommbendall
Copy link
Contributor

This fixes our physics capability, to give us real control over which physics schemes are called and when.

This is done by:

  • the Physics class is renamed as PhysicsParametrisation which will help us avoid confusion
  • introducing a PhysicsLabel which is a type of new type of label, which actually gives a term two labels:
    • physics: with the value as a string describing the physics parametrisation
    • the unique label for that parametrisation, which stores the evaluate method as before
  • ensuring that each PhysicsParametrisation object has a label
  • when the TimeDiscretisation sets up its evaluate methods, it now ensures that they are unique
  • a rogue extra call to evaluate physics schemes has been removed

@tommbendall tommbendall merged commit 42954c4 into main Sep 26, 2023
4 checks passed
@tommbendall tommbendall deleted the physics_labels branch September 26, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants