-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organise and enhance spherical coordinate transforms #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshipton
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some handy routines for spherical coordinate transforms, and reorganises some of our existing ones. This addresses #335 .
There are quite aspects to this change:
Underpinning these new routines is the aim to have a set of routines that can be used both with Firedrake expressions and numpy arrays.
The model's internal coordinates can now be rotated (lon,lat,r) coordinates. The rotation of coordinates is threaded through the model by passing it to the
Domain
andCoordinates
objects. The rotated coordinates are now used in the Williamson 2 test.There is now a calculation in the
Domain
object to evaluate the radius of the mesh that has been provided. When outputting for a 3D spherical domain, the vertical coordinate is nowr-radius
instead ofr
.The vector component diagnostics have been consolidated and use the rotation capability.
There are unit-tests for all of the new routines.