-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate PointDataOutput? #416
Comments
What is going on here is that this example uses the "point-data" output capability, which does not work in parallel. This "point-data" outputting is now quite old, and uses the The short term fix for this example is just to remove the "point-data" outputting for this example, since we don't actually use the output, it's just in this example to ensure that we still test this capability. The longer term fix is either to remove "point-data" outputting or to test it properly (and fail gracefully if we try to use it in parallel). I suggest we leave this issue open for Jemma to comment on before making a longer-term decision, but I would be happy for you to remove the "point-data" output from that example for now. **other than bugs with it that Jack steadily finds xD |
Line 75 in 4882454
Non-hydrostatic Compressible Skamarock Klemp will print a warning if you run in parallel:
Hopefully all the tests pass on the new PR 🤞 I will change the title of this issue to reflect why it's being kept open. |
It should use VertexOnlyMesh now. I can explain how to do this soon.
This will also be nice for Reuben to have application in a model.
On 2 Aug 2023, at 15:48, Jack Betteridge ***@***.***> wrote:
PointDataOutput now raises an exception if you try to construct it in parallel: https://github.com/firedrakeproject/gusto/blob/4882454132dd119da39630dc7e51ec7f47dabc75/gusto/io.py#L75
Non-hydrostatic Compressible Skamarock Klemp will print a warning if you run in parallel: https://github.com/firedrakeproject/gusto/blob/4882454132dd119da39630dc7e51ec7f47dabc75/examples/compressible/skamarock_klemp_nonhydrostatic.py#L66
Hopefully all the tests pass on the new PR 🤞
I will change the title of this issue to reflect why it's being kept open.
—
Reply to this email directly, view it on GitHub<#416 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABOSV4SGBUGMOYNFCN5BWYDXTJZFPANCNFSM6AAAAAA3BJ5W6A>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
The non-hydrostatic Skamarock Klemp example does not run in parallel, is this expected?
Full traceback below:
The text was updated successfully, but these errors were encountered: