Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another integration, fix whitespace around punctuation #31

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

astro
Copy link
Contributor

@astro astro commented Oct 13, 2023

Reason for this PR

Except in French, there is no whitespace preceding punctuation marks.

Description of changes

Links to a project that makes it easy to run NixOS VMs on Firecracker.

License acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT-0 [1] license.

[1] https://github.com/aws/mit-0

PR checklist

[Author TODO: Meet these criteria & check the boxes.]
[Reviewer TODO: Verify checked boxes. Request changes if criteria not met]

  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • All commits in this PR are signed (git commit -s).

@xmarcalx xmarcalx self-requested a review October 16, 2023 09:40
Copy link
Contributor

@xmarcalx xmarcalx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @astro,

Thank you very much for the changes and welcome to Firecracker community.
I left some minor comments. Would you be ok for you to address them?

index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@xmarcalx xmarcalx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving the issues!

@xmarcalx xmarcalx merged commit 8dbc9c7 into firecracker-microvm:main Oct 17, 2023
@xmarcalx xmarcalx mentioned this pull request Oct 17, 2023
3 tasks
@astro astro deleted the integrations branch October 17, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants