-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added snapshot documentation + pipeline example code #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginglis13
requested changes
Jul 29, 2022
austinvazquez
requested changes
Jul 30, 2022
sondavidb
force-pushed
the
snapshot-docs
branch
7 times, most recently
from
August 1, 2022 22:41
2163436
to
239afca
Compare
ginglis13
requested changes
Aug 1, 2022
sondavidb
force-pushed
the
snapshot-docs
branch
from
August 1, 2022 23:51
239afca
to
ff2eb80
Compare
austinvazquez
approved these changes
Aug 2, 2022
ginglis13
requested changes
Aug 2, 2022
sondavidb
force-pushed
the
snapshot-docs
branch
from
August 2, 2022 18:54
ff2eb80
to
018b722
Compare
Signed-off-by: David Son <[email protected]>
sondavidb
force-pushed
the
snapshot-docs
branch
from
August 2, 2022 20:41
018b722
to
02a98ea
Compare
ginglis13
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Son [email protected]
Issue #, if available:
#423
Description of changes:
Documenting changes made in #414 as well as creating a working example of snapshots in the SDK that is tested in the pipeline to ensure relevancy. It may be redundant due to it being very similar to
TestLoadSnapshot()
inmachine.go
but I feel having a prepackaged way for users to easily test snapshotting capabilities is very useful. Feel free to discuss below.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.