-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrong line number in stack trace #1377
Conversation
1334fd6
to
3f2f046
Compare
3f2f046
to
104357d
Compare
merge with master please @ANGkeith |
104357d
to
84f7a78
Compare
@ANGkeith We need to ensure that stack traces in the pkg binaries still works, when you remove the sourcemap package. |
opps, forgot about that.. but do we really need sourcemap for the binary ? i thought sourcemap is more for dev/debugging |
b0574a3
to
42219d6
Compare
npm uninstall ts-node source-map-support @types/source-map-support npm install --save-dev tsx
42219d6
to
310673a
Compare
anyways,
should be fixed already |
|
@ANGkeith We don't have any security concerns going on in this tool, so I can't think of a reason why we would want to exclude such epic piece of debug information, when users make bug reports. |
npm uninstall ts-node source-map-support @types/source-map-support
npm install --save-dev tsx
Issue
Using the following
The stack trace returns the wrong line number.
which is possibly related to https://www.github.com/TypeStrong/ts-node/issues/2053, thus replacing
ts-node
withtsx