fix: afterscript should be reusing the same container

firecow · Oct 1, 2024 · 7d3b2f6 · 7d3b2f6
1 parent 49ee889
commit 7d3b2f6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/job.ts b/src/job.ts
@@ -689,7 +689,7 @@ export class Job {
 
         this.refreshLongRunningSilentTimeout(writeStreams);
 
-        if (imageName) {
+        if (imageName && !this._containerId) {
             await this.pullImage(writeStreams, imageName);
 
             let dockerCmd = `${this.argv.containerExecutable} create --interactive ${this.generateInjectSSHAgentOptions()} `;

diff --git a/tests/test-cases/after-script/.gitlab-ci.yml b/tests/test-cases/after-script/.gitlab-ci.yml
@@ -4,9 +4,12 @@ default:
     - echo "Cleanup after test"
 
 test-job:
+  image: busybox
   script:
     - echo "Test something"
+    - echo "cache" > /tmp/cache
   after_script:
+    - rm /tmp/cache
     - echo "Cleanup after test"
 
 build-job: