Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(FIR-34713): Add missing classifiers to setup.cfg #403

Merged
merged 2 commits into from
Sep 9, 2024
Merged

chore(FIR-34713): Add missing classifiers to setup.cfg #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50a57e7
chore(FIR-34713): Add missing classifiers to setup.cfg
ptiurin Sep 5, 2024
0a2674b
fix upload artifact
ptiurin Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/unit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,12 @@ jobs:
uses: actions/checkout@v2
with:
ref: ${{ inputs.branch }}

- name: Set up Python 3.8
uses: actions/setup-python@v2
with:
python-version: 3.8

- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand All @@ -40,7 +40,7 @@ jobs:
- name: Run unit tests
run: |
pytest --cov=src/ tests/unit --cov-report=xml --alluredir=allure-results

- name: Get Allure history
uses: actions/checkout@v2
if: always()
Expand All @@ -57,12 +57,12 @@ jobs:
github-key: ${{ secrets.GITHUB_TOKEN }}

- name: Upload coverage report
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
continue-on-error: true
with:
name: pytest-coverage-report
path: coverage.xml

- name: Extract coverage percent
id: coverage
if: github.event_name == 'push'
Expand All @@ -74,7 +74,7 @@ jobs:
colour=$(if [ $percentage_whole -ge 80 ]; then echo "green"; else echo "orange"; fi)
echo "colour=$colour" >> $GITHUB_OUTPUT
echo "covered=$percentage_whole" >> $GITHUB_OUTPUT

- name: Create Coverage Badge
uses: schneegans/[email protected]
if: github.event_name == 'push'
Expand Down
4 changes: 3 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ repos:
- id: check-merge-conflict

- repo: https://github.com/asottile/setup-cfg-fmt
rev: v1.17.0
rev: v2.5.0
hooks:
- id: setup-cfg-fmt
args:
- --include-version-classifiers

- repo: https://github.com/myint/autoflake
rev: v1.4
Expand Down
7 changes: 5 additions & 2 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,17 @@ url = https://github.com/firebolt-db/firebolt-sdk
author = Firebolt
author_email = [email protected]
license = Apache-2.0
license_file = LICENSE
license_files = LICENSE
classifiers =
License :: OSI Approved :: Apache Software License
Operating System :: OS Independent
Programming Language :: Python :: 3
Programming Language :: Python :: 3 :: Only
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Programming Language :: Python :: 3.12
project_urls =
Bug Tracker = https://github.com/firebolt-db/firebolt-sdk/issues

Expand Down Expand Up @@ -51,7 +54,7 @@ dev =
allure-pytest==2.*
devtools==0.7.0
mypy==1.*,<1.10.0
pre-commit==2.15.0
pre-commit==3.5.0
pyfakefs>=4.5.3
pytest==7.2.0
pytest-cov==3.0.0
Expand Down
Loading