Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Fir 33557 remove account v 1 fb 2 0 support in python sdk #390

Merged
merged 36 commits into from
Jun 26, 2024
Merged

refactor: Fir 33557 remove account v 1 fb 2 0 support in python sdk #390

merged 36 commits into from
Jun 26, 2024

Conversation

stepansergeevitch
Copy link
Collaborator

Changes related to removal of account v1 + fb 2.0 support

  • Refactored out all related logic
  • Fixed and added unit tests
  • Refactored all fb1.0 unit tests into a separate directory
  • updated CI

@stepansergeevitch stepansergeevitch self-assigned this Jun 17, 2024
@stepansergeevitch stepansergeevitch requested a review from a team as a code owner June 17, 2024 13:02
@stepansergeevitch stepansergeevitch changed the title Fir 33557 remove account v 1 fb 2 0 support in python sdk refactor: Fir 33557 remove account v 1 fb 2 0 support in python sdk Jun 17, 2024
ptiurin
ptiurin reviewed Jun 18, 2024
View reviewed changes
@stepansergeevitch
remove account v1 connection logic
2e3b7c6
@stepansergeevitch
cleanup
de939ff
@stepansergeevitch
remove adding account id logic
5155e5f
@stepansergeevitch
client minor refactoring
8713346
@stepansergeevitch
rename server->api_endpoint
81a4835
@stepansergeevitch
move all v1 tests to a single folder
d1a69e0
@stepansergeevitch
refactor out v1 fixtures
9108bec
@stepansergeevitch
fix import
847b595
@stepansergeevitch
fix client tests
1695320
@stepansergeevitch
move database to init_params for v2 connection
b6a1134
@stepansergeevitch
implement client clone
a08def1
@stepansergeevitch
clone client for cursor, remove system engine connection
4524150
@stepansergeevitch
fix test_util
f9a7feb
@stepansergeevitch
fix sync connection tests
bdc21bd
@stepansergeevitch
fix async connection tests
bb7aca4
@stepansergeevitch
fix cursor tests
300a742
@stepansergeevitch
fix v1 connection tests
d9e7b05
@stepansergeevitch
refactor v1 fixtures
74519b4
@stepansergeevitch
fix v1 tests
7fdad7d
@stepansergeevitch
update models
504b641
@stepansergeevitch
update services
123db9e
@stepansergeevitch
fix service databases tests
1cfcab5
@stepansergeevitch
fix services tests
41f6479
@stepansergeevitch
remove redundant account_id call
f5d1490
@stepansergeevitch
only store engine url in connection
c49fd2f
@stepansergeevitch
remove integration tests account markers
6116826
@stepansergeevitch stepansergeevitch force-pushed the FIR-33557-remove-account-v-1-fb-2-0-support-in-python-sdk branch from a3cf481 to c7695af Compare June 19, 2024 07:53
ptiurin
ptiurin approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@stepansergeevitch stepansergeevitch merged commit 25c9a70 into main Jun 26, 2024
6 of 7 checks passed
@stepansergeevitch stepansergeevitch deleted the FIR-33557-remove-account-v-1-fb-2-0-support-in-python-sdk branch June 26, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptiurin ptiurin ptiurin approved these changes

Assignees

@stepansergeevitch stepansergeevitch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepansergeevitch @ptiurin