Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Receiving account version 2 #352

Merged
merged 4 commits into from
Feb 12, 2024
Merged

feat: Receiving account version 2 #352

merged 4 commits into from
Feb 12, 2024

Conversation

ptiurin
Copy link
Collaborator

@ptiurin ptiurin commented Feb 9, 2024

Part of FIR-30151

Adding support for a new field in account resolution call. It will be used in the future to adjust error checking and internal logic.

Setting it to "private" to indicate this should not be directly touched by the user.

Firebolt V1 uses a different url to resolve account name so I'm hardcoding this parameter for completion.

@ptiurin
Copy link
Collaborator Author

ptiurin commented Feb 9, 2024

TODO: add org variables for account V1 and V2

@ptiurin ptiurin marked this pull request as ready for review February 9, 2024 19:25
@ptiurin ptiurin requested a review from a team as a code owner February 9, 2024 19:25
Copy link

@ptiurin ptiurin merged commit fdba33b into main Feb 12, 2024
7 checks passed
@ptiurin ptiurin deleted the feat-account-version-2 branch February 12, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants