Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run only failed tests when re-running #281

Merged
merged 26 commits into from
Jul 20, 2023

Conversation

RotemFB
Copy link
Contributor

@RotemFB RotemFB commented Jul 13, 2023

using cache in the ci in order to re-run only the failed tests in order to save some time

@RotemFB RotemFB self-assigned this Jul 13, 2023
@RotemFB RotemFB changed the title dummy Test for re runnung failed tasks ci: run only failed tests when re-running Jul 18, 2023
@RotemFB RotemFB marked this pull request as ready for review July 18, 2023 10:43
@RotemFB RotemFB requested a review from ptiurin July 18, 2023 10:43
- name: Save failed tests
id: cache-tests-save
uses: actions/cache/save@v3
if: always()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would even put here if: failure() so we don't bother trying to save nothing when nothing fails.

- name: Save failed tests
id: cache-tests-save
uses: actions/cache/save@v3
if: always()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's worth adding to unit tests at all - they run in seconds and rerunning them is no big deal. Let's keep them simple!

Copy link
Collaborator

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just trim the whitespace in unit-test.yml to keep the changelog clean

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@RotemFB RotemFB merged commit 4e84a00 into 0.x Jul 20, 2023
@RotemFB RotemFB deleted the test_fot_re_runnung_failed_tasks branch July 20, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants