fix: Fir 14026 frequently get attributeerror #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
changed the title
ptiurin
approved these changes
Jun 21, 2022
Comment on lines
+26
to
+31
| for backend in ("asyncio", "trio"): | ||
| try: | ||
| get_asynclib(backend) | ||
| except ModuleNotFoundError: | ||
| # Not all backends might be installed | ||
| pass |
There was a problem hiding this comment.
I'm just worried since we're using a "private" API for this hack it might change without notice. As we're pinning the httpx version we're fine for now, but if we were to upgrade it might cause issues. Hopefully it will be picked up by nightly.
There was a problem hiding this comment.
I will investigate how this could be properly fixed
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed anyio race condition, which happened when it was lazily importing async backend modules. Now we always import all available backends on the module-level, so this issues doesn't occur anymore. Added integration test