fix: Fir 11539 setting non existing account n #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
changed the title
ptiurin
reviewed
Jun 6, 2022
src/firebolt/async_db/connection.py
Outdated
Comment on lines
225
to
227
| elif account_name: | ||
| # We need to manually validate account_name since it's not validated | ||
| # in neither of above cases |
There was a problem hiding this comment.
Should it be if instead? So if above cases pass it still validates the account name?
There was a problem hiding this comment.
Account name gets validated in those cases since it's used to get/resolve engine url.
I'll extend a comment explaining that
stepansergeevitch
force-pushed
the
FIR-11539-setting-non-existing-account_n
branch
from
cb3b4bb to
4320c98
Compare
ptiurin
approved these changes
Jun 6, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed missing errors for invalid account_name for
ResourceManagerandconnect