Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fir 13884 fix import backward compatibil #173

Merged
merged 2 commits into from
Jun 3, 2022
Merged

fix: Fir 13884 fix import backward compatibil #173

merged 2 commits into from
Jun 3, 2022

Conversation

stepansergeevitch
Copy link
Collaborator

Added mock modules to firebolt.common to have backward compatible imports

@stepansergeevitch stepansergeevitch self-assigned this Jun 1, 2022
@stepansergeevitch stepansergeevitch changed the title Fir 13884 fix import backward compatibil fix: Fir 13884 fix import backward compatibil Jun 1, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@stepansergeevitch stepansergeevitch merged commit 84af14b into main Jun 3, 2022
@stepansergeevitch stepansergeevitch deleted the FIR-13884-fix-import-backward-compatibil branch June 3, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptiurin ptiurin ptiurin approved these changes

@yuryfirebolt yuryfirebolt Awaiting requested review from yuryfirebolt

Assignees

@stepansergeevitch stepansergeevitch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepansergeevitch @ptiurin