fix: engine incorrect auto_stop update in case it is 0 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptiurin
approved these changes
Apr 28, 2022
| @@ -354,7 +354,9 @@ class _EngineUpdateRequest(FireboltBaseModel): | |||
| # Update engine settings | |||
| engine_settings_params = { | |||
| "engine_type": engine_type, | |||
| "auto_stop_delay_duration": f"{auto_stop * 60}s" if auto_stop else None, | |||
| "auto_stop_delay_duration": f"{auto_stop * 60}s" | |||
| if auto_stop is not None | |||
There was a problem hiding this comment.
While we're at it should we exclude negative numbers as well?
There was a problem hiding this comment.
So far we don't do any input validation. It is just when auto_stop was set to zero, which is a valid value, the if statement didn't allow to propagate it.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.