Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fir 12879 allow skipping token caching #159

Merged
merged 5 commits into from
Apr 20, 2022

Conversation

stepansergeevitch
Copy link
Collaborator

Added ability to disable token caching.
It now could be disabled withuse_token_cache=False, provided as a connect function argument or as a Settings field.
Added unit tests

@stepansergeevitch stepansergeevitch self-assigned this Apr 19, 2022
@stepansergeevitch stepansergeevitch changed the title Fir 12879 allow skipping token caching feat: Fir 12879 allow skipping token caching Apr 19, 2022
Copy link
Contributor

@yuryfirebolt yuryfirebolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stepansergeevitch stepansergeevitch force-pushed the FIR-12879-allow-skipping-token-caching-i branch from 52f7592 to da39910 Compare April 20, 2022 10:40
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.3% 89.3% Coverage
0.0% 0.0% Duplication

@stepansergeevitch stepansergeevitch merged commit 9c22175 into main Apr 20, 2022
@stepansergeevitch stepansergeevitch deleted the FIR-12879-allow-skipping-token-caching-i branch April 20, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants