feat(FIR-35165): Optional external id for arn auth #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stepansergeevitch
approved these changes
Jul 30, 2024
| if [[ -n "$AWS_ACCESS_ROLE_ARN" ]]; then | ||
| # Can't test this on FB 1.0 | ||
| cp ../dbt-firebolt/.github/workflows/jaffle_shop/sources_external_tables_iam.yml models/staging/sources_external_tables.yml | ||
| dbt run-operation stage_external_sources --vars "ext_full_refresh: true" |
There was a problem hiding this comment.
We already run this operation before this if block. Can we just execute it once after the if block?
There was a problem hiding this comment.
That's intentional - we're changing the table configuration by doing cp into sources_external_tables.yml. First time we're testing no auth, then auth with id and secret and finally (conditional, on fb2.0) IAM role auth. Each one of them to trigger needs dbt run-operation
ptiurin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per our docs ARN auth's external id is optional. Reflecting this in code.
Also adding a test for arn auth. Passing.
Checklist
changie newand committed everything in .changes folder