Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename --export flag to --export-release #95

Conversation

AntonioDell
Copy link
Contributor

@AntonioDell AntonioDell commented Nov 18, 2022

Godot 4 beta 5 changed the --export flag to be more explicit about what is happening (see godotengine/godot#60273). By doing this, the godot-export action would not work when being used with Godot 4 beta 5 and upwards.

This fix will break compatibility with Godot 4 beta 4 and below!

The following test build was done with these changes: https://github.com/AntonioDell/godot-export/releases/tag/v7-test

Godot 4 beta 5 changed the --export flag to be more explicit about what is happening (see godotengine/godot#60273).
By doing this, the godot-export action would not work when being used with Godot 4 beta 5 and upwards.
This fix will break compatibility with Godot 4 beta 4 and below!
Copy link
Owner

@firebelley firebelley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Breaking changes are ok while Godot is in Beta.

@firebelley firebelley merged commit dcea5e5 into firebelley:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants