Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache restore causes Godot URL changes to be ignored #118

Closed
Spartan322 opened this issue Jul 18, 2023 · 0 comments
Closed

Cache restore causes Godot URL changes to be ignored #118

Spartan322 opened this issue Jul 18, 2023 · 0 comments

Comments

@Spartan322
Copy link
Contributor

Spartan322 commented Jul 18, 2023

When restoring the Godot files from the cache, this action completely ignores a new url for no reason, the cache should not restore a key from a different file, this makes it impossible to use the cache functionality and update their exports. (or change your download urls for any reason)

const restoreKey = `godot-templates-`;

should become

  const restoreKey = `godot-templates-${GODOT_TEMPLATES_DOWNLOAD_URL}`;

and

const restoreKey = `godot-executable-`;

should become

  const restoreKey = `godot-executable-${GODOT_DOWNLOAD_URL}`;

See #119

Spartan322 added a commit to Spartan322/godot-export that referenced this issue Jul 18, 2023
Spartan322 added a commit to Spartan322/godot-export that referenced this issue Jul 18, 2023
Spartan322 added a commit to Spartan322/godot-export that referenced this issue Jul 18, 2023
Spartan322 added a commit to Spartan322/godot-export that referenced this issue Jul 18, 2023
Spartan322 added a commit to Spartan322/godot-export that referenced this issue Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant