Skip to content

Commit

Permalink
update readme and add lint step to build
Browse files Browse the repository at this point in the history
  • Loading branch information
firebelley committed Apr 29, 2020
1 parent cec6eea commit 31d8f1c
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ Since this action creates releases and uploads the zip file assets, you will nee
- Enable release creation. If `false`, exports will be available in folder `exports` in `relative_project_path`.
- `generate_release_notes` default `false`
- Enable auto-generation of release notes based on commit history.
- `zip_export` default `true`
- If `create_release` is `false`, this input determines whether the binaries are zipped when moved to the `exports` directory in `relative_project_path`. If `true`, the binaries are zipped. If `false`, the subdirectories containing the binaries are moved into the `exports` directory.

### Example Workflow Configuration
Below is a sample workflow configuration file utilizing this action. This example workflow would be defined in `.github/workflows/main.yml`. For more information about defining workflows [check out the workflow docs](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/configuring-a-workflow).
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Exports Godot games.",
"main": "lib/main.js",
"scripts": {
"build": "ncc build ./src/main.ts -o dist",
"build": "yarn lint && ncc build ./src/main.ts -o dist",
"test": "echo \"Error: no test specified\" && exit 1",
"lint": "eslint . --ext .ts"
},
Expand Down
3 changes: 1 addition & 2 deletions src/godot.ts
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,7 @@ async function moveExports(exportResults: ExportResult[]): Promise<number> {
for (const exportResult of exportResults) {
if (shouldZipExport) {
promises.push(move(await zip(exportResult)));
}
else {
} else {
promises.push(moveDirectory(exportResult.buildDirectory));
}
}
Expand Down
9 changes: 8 additions & 1 deletion src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,4 +124,11 @@ function logAndExit(error: Error): void {

main().catch(logAndExit);

export { actionWorkingPath, relativeProjectPath, relativeProjectExportsPath, getGitHubClient, getLatestReleaseTagName, shouldZipExport };
export {
actionWorkingPath,
relativeProjectPath,
relativeProjectExportsPath,
getGitHubClient,
getLatestReleaseTagName,
shouldZipExport,
};

0 comments on commit 31d8f1c

Please sign in to comment.