feat: Functions Quickstart Kotlin #640
Conversation
|
@rosariopfernandes regarding the build failure here : You might want to add the constraint-layout dependency explicitly to your module's I bumped into the same issue with the auth quickstart. |
|
Thank you very much @the-dagger I'll give this a try! |
|
Here's what I did for the ConstraintLayout fix: I made the |
|
@the-dagger 's solution doesn't seem to have fixed it. I'll try @samtstern 's solution now. |
|
There we go. Build fixed. Thanks for the tips guys |
| */ | ||
| class MainActivity : AppCompatActivity(), View.OnClickListener { | ||
|
|
||
| // [START define_functions_instance] |
There was a problem hiding this comment.
@samtstern I've noticed those are the java snippets present on the documentation. Shouldn't we move them to the snippets repo?
There was a problem hiding this comment.
@rosariopfernandes good question! For now we are going to leave them where they are. But we have stopped writing new snippets in the quickstart repo.
I am making sure that as I merge these PRs I update the doc references to point to the new paths (the auth PR moved like 50+ snippets)
| createNotificationChannel() | ||
|
|
||
| // Check if message contains a data payload. | ||
| if (remoteMessage!!.data.isNotEmpty()) { |
There was a problem hiding this comment.
Maybe instead of !! just do this above:
if (remoteMessage == null) {
return;
}There was a problem hiding this comment.
Actually, this was my mistake. I had annotated the remoteMessage argument as nullable. I think there's no reason for that, I'll remove the notation.
| showSnackbar("Error signing in.") | ||
|
|
||
| val response = IdpResponse.fromResultIntent(data) | ||
| Log.w(TAG, "signIn", response!!.error) |
| // Register the channel with the system; you can't change the importance | ||
| // or other notification behaviors after this | ||
| val notificationManager = getSystemService(NotificationManager::class.java) | ||
| notificationManager!!.createNotificationChannel(channel) |
| // [START function_add_numbers] | ||
| private fun addNumbers(a: Int, b: Int): Task<Int> { | ||
| // Create the arguments to the callable function, which are two integers | ||
| val data = HashMap<String, Any>() |
There was a problem hiding this comment.
nit: maybe use the hashMapOf syntax:
hashMapOf(
"John" to "Doe",
"Jane" to "Smith"
)
| // [START function_add_message] | ||
| private fun addMessage(text: String): Task<String> { | ||
| // Create the arguments to the callable function. | ||
| val data = HashMap<String, Any>() |
There was a problem hiding this comment.
Same nit here about the map
|
Will merge after build |
Fixes #631