Convert firestore quickstart to Kotlin #638
Conversation
Change-Id: I3995228bb5b924cf3d63a1906dd8b461088759c0
Change-Id: Ieeeebb59750672b9126f9d039a8736341a640492
Change-Id: I1e7a8d63b8b65fbbcefaaddc11c8b8008bfc55af
Change-Id: I0f71b80b14306b9a790b3663b23e3bdb4c63f8ac
samtstern
changed the title
|
@the-dagger @rosariopfernandes if either one of you has time to review, this one is ready to go. If not I can get someone on my team to review, don't need to take up all of your time! |
|
@samtstern Sure, I'll have a look. |
firestore/app/src/main/java/com/google/firebase/example/fireeats/java/FilterDialogFragment.java
Show resolved
Hide resolved
| } | ||
|
|
||
| fun onSearchClicked() { | ||
| if (filterListener != null) { |
There was a problem hiding this comment.
I think that this can be replaced with a safe call. ?.
There was a problem hiding this comment.
I believe this would do:
filterListener?.let{
filterListener.onFilter(filters)
}There was a problem hiding this comment.
Yep, correct.
Also, I think that
filterListener?.onFilter(filters)
would work just fine as well, no need for the let block.
What do you think @rosariopfernandes?
|
|
||
| // Sort by (orderBy with direction) | ||
| if (filters.hasSortBy()) { | ||
| query = query.orderBy(filters.sortBy!!, filters.sortDirection!!) |
There was a problem hiding this comment.
Instead of !! can we use toString() on these params?
|
|
||
| override fun onResume() { | ||
| super.onResume() | ||
| dialog.window!!.setLayout( |
There was a problem hiding this comment.
Personally, I think that we should avoid the not-null assertion operator (!!) as much as we can.
Leads to undesirable NPEs!
| restaurantFormRating.rating.toDouble(), | ||
| restaurantFormText.text.toString()) | ||
|
|
||
| if (ratingListener != null) { |
There was a problem hiding this comment.
Same, can be replaced with a safe call operator ?.
firestore/app/src/main/java/com/google/firebase/example/fireeats/kotlin/FilterDialogFragment.kt
Outdated
Show resolved
Hide resolved
| /** | ||
| * Model POJO for a rating. | ||
| */ | ||
| class Rating { |
There was a problem hiding this comment.
Can we use a data class here?
| * Restaurant POJO. | ||
| */ | ||
| @IgnoreExtraProperties | ||
| class Restaurant { |
Change-Id: I063d6190ca8136a83249b37c48e2d643df74067e
Change-Id: I08a033f6a890efca393da5faa073ba1495273af5
Change-Id: I1c97a006b23e32f5b35a7e8640b83c42b98a323a
Fixes #630