Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart updates #1188

Merged
merged 8 commits into from
Oct 29, 2020
Merged

Quickstart updates #1188

merged 8 commits into from
Oct 29, 2020

Conversation

MeghaB
Copy link
Contributor

@MeghaB MeghaB commented Oct 6, 2020

Explicitly specific activity for callback binding, use PhoneAuthOptions

MeghaB added 2 commits October 5, 2020 17:40
Explicitly specific activity for callbackbinding, use PhoneAuthOptions
Copy link
Member

@thatfiredev thatfiredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but I don't think we need these semicolons in Kotlin 😉

Comment on lines 160 to 161
.build();
PhoneAuthProvider.verifyPhoneNumber(options);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.build();
PhoneAuthProvider.verifyPhoneNumber(options);
.build()
PhoneAuthProvider.verifyPhoneNumber(options)

Comment on lines 185 to 186
.build();
PhoneAuthProvider.verifyPhoneNumber(options);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.build();
PhoneAuthProvider.verifyPhoneNumber(options);
.build()
PhoneAuthProvider.verifyPhoneNumber(options)

@MeghaB MeghaB marked this pull request as ready for review October 29, 2020 02:10
@MeghaB MeghaB merged commit 6edf587 into master Oct 29, 2020
@thatfiredev thatfiredev deleted the auth_20.0.0 branch May 3, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants