Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test modular android action #1175

Closed
wants to merge 1 commit into from
Closed

chore: test modular android action #1175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ jobs:
- name: Copy mock google_services.json
run: ./copy_mock_google_services_json.sh
- name: Build with Gradle (Pull Request)
run: ./build_pull_request.sh
uses: rosariopfernandes/[email protected]
with:
for-each-module: 'assembleDebug'
if: github.event_name == 'pull_request'
- name: Build with Gradle (Push)
run: ./gradlew clean ktlint build
Expand Down
2 changes: 2 additions & 0 deletions admob/app/src/main/java/com/google/samples/quickstart/admobexample/kotlin/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ class MainActivity : AppCompatActivity() {
adView.loadAd(adRequest)
// [END load_banner_ad]

// Please only build admob

// AdMob ad unit IDs are not currently stored inside the google-services.json file.
// Developers using AdMob can store them as custom values in a string resource file or
// simply use constants. Note that the ad units used here are configured to return only test
Expand Down