Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#101 Implementation. Add observers with snapshots. #128

Merged
merged 3 commits into from
Oct 14, 2019
Merged

#101 Implementation. Add observers with snapshots. #128

merged 3 commits into from
Oct 14, 2019

Conversation

exxbrain
Copy link
Contributor

@exxbrain exxbrain commented Aug 31, 2019 •
edited
Loading

Add ability to use complete snapshots when handling events. +Add scheme to example project to fix its build.

@exxbrain exxbrain changed the title Add observers with snapshots #101 Implementation. Add observers with snapshots. Aug 31, 2019
morganchen12
morganchen12 reviewed Sep 3, 2019
View reviewed changes
GeoFire/API/GFQuery.h Outdated Show resolved Hide resolved
GeoFire/Implementation/GFQuery.m Outdated Show resolved Hide resolved
@morganchen12
Copy link
Contributor

Thanks for doing this, looks mostly good--had a few small questions.

@morganchen12
Copy link
Contributor

LGTM 👍

@morganchen12 morganchen12 merged commit 68b4844 into firebase:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exxbrain @morganchen12