Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate in_app_messaging to sound null safety #5676

Merged
merged 5 commits into from
Apr 13, 2021
Merged

feat: migrate in_app_messaging to sound null safety #5676

merged 5 commits into from
Apr 13, 2021

Conversation

atrope
Copy link
Contributor

@atrope atrope commented Apr 6, 2021

Description

This migrates firebase_in_app_messaging to non-nullable types

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

This is a "Breaking" Change because it is upgrading to null safety, the user code will not be needed to change as the dart lib was almost ready to be null safe already checking for null value and throwing error

@google-cla google-cla bot added the cla: yes label Apr 6, 2021
## 1.0.0

- **CHORE**: bump packages.
- **BREAKING** **FEAT**: Migrate firebase_in_app_messaging to sound null safety
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelogs are generated, could you remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rrousselGit
Copy link
Contributor

Thanks! Could you update the tests too?

@atrope
Copy link
Contributor Author

atrope commented Apr 6, 2021

@rrousselGit sure! Updated also the example to use Sound Null safety and tested :)

Copy link
Contributor

@rrousselGit rrousselGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after you've removed the version bump 😄

Co-authored-by: Remi Rousselet <[email protected]>
@atrope
Copy link
Contributor Author

atrope commented Apr 6, 2021

LGTM after you've removed the version bump 😄

Didn't know that it was done only at release.
Done!

@atrope
Copy link
Contributor Author

atrope commented Apr 7, 2021

Hey @rrousselGit ,
What is the scheduled plan for merging and bumping version?
This is the last plugin needed for us to go full sound null safety and maybe some others are also needing this bump

@rrousselGit
Copy link
Contributor

We typically do release on Monday. You can use a git dependency in the meantime

@zetflo
Copy link

zetflo commented Apr 13, 2021

Hello, can you merge this PR ?
🙏

@russellwheatley russellwheatley merged commit ce2f728 into firebase:master Apr 13, 2021
@zetflo
Copy link

zetflo commented Apr 13, 2021

👍

@Salakar
Copy link
Member

Salakar commented Apr 14, 2021

This has now been published to pub.dev - thanks everyone.

@firebase firebase locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants