-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate in_app_messaging to sound null safety #5676
feat: migrate in_app_messaging to sound null safety #5676
Conversation
## 1.0.0 | ||
|
||
- **CHORE**: bump packages. | ||
- **BREAKING** **FEAT**: Migrate firebase_in_app_messaging to sound null safety |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelogs are generated, could you remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Thanks! Could you update the tests too? |
@rrousselGit sure! Updated also the example to use Sound Null safety and tested :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after you've removed the version bump 😄
Co-authored-by: Remi Rousselet <[email protected]>
Didn't know that it was done only at release. |
Hey @rrousselGit , |
We typically do release on Monday. You can use a git dependency in the meantime |
Hello, can you merge this PR ? |
👍 |
This has now been published to pub.dev - thanks everyone. |
Description
This migrates firebase_in_app_messaging to non-nullable types
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
This is a "Breaking" Change because it is upgrading to null safety, the user code will not be needed to change as the dart lib was almost ready to be null safe already checking for null value and throwing error