Fixing issue with firebase init genkit on Windows #8011
+111
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8011 +/- ##
==========================================
- Coverage 51.19% 51.18% -0.01%
==========================================
Files 423 423
Lines 29544 29550 +6
Branches 6031 6031
==========================================
+ Hits 15125 15126 +1
- Misses 13059 13064 +5
Partials 1360 1360 ☔ View full report in Codecov by Sentry. |
joehan
approved these changes
Dec 2, 2024
| "For a possible workaround run\n npm view genkit version\n" + | ||
| "and then set an environment variable:\n" + | ||
| " export GENKIT_DEV_VERSION=<output from previous command>\n" + | ||
| "and try the firebase init command again", |
There was a problem hiding this comment.
Suggested change
| "and try the firebase init command again", | |
| "and run `firebase init` again", |
| @@ -482,7 +483,7 @@ export async function writeSDK( | |||
| // Build it | |||
| logLabeledBullet("extensions", `running 'npm --prefix ${shortDirPath} run build'`); | |||
| try { | |||
| execFileSync("npm", ["--prefix", dirPath, "run", "build"]); | |||
| await spawnWithOutput("npm", ["--prefix", dirPath, "run", "build"]); | |||
There was a problem hiding this comment.
Nit: Since we don't use the output, should we be using wrapSpawn in this file instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue with firebase init genkit on Windows.