Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have 'firebase firestore:delete' retry on bandwidth RESOURCE_EXHAUSTED errors #7863

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

NickChittle
Copy link
Contributor

@NickChittle NickChittle commented Oct 22, 2024

Description

Have 'firebase firestore:delete' retry on bandwidth RESOURCE_EXHAUSTED errors

Fixes #7845

Scenarios Tested

Tested on a locally setup database with several thousands 1MB Documents.

Sample Commands

firebase firestore:delete -r "large-collection" --debug

@NickChittle NickChittle requested a review from joehan October 22, 2024 19:59
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can you add an entry for this to CHANGELOG.md?

@NickChittle NickChittle enabled auto-merge (squash) October 22, 2024 20:02
@NickChittle NickChittle merged commit 5c53ccd into master Oct 22, 2024
40 of 41 checks passed
@joehan joehan deleted the firestore_delete_bandwidth branch October 22, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot delete a collection with firestore:delete due to HTTP Error 429
2 participants