Use 'default' alias if there are multiple aliases #7804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredzqm
reviewed
Oct 7, 2024
| // support deprecated "firebase" key in firebase.json | ||
| if (options.config && !options.project) { | ||
| options.project = options.config.defaults.project; | ||
| } | ||
|
|
||
| const aliases = rc.projects; | ||
| const rcProject = get(aliases, options.project); | ||
| const rcProject = options.project ? aliases[options.project] : undefined; |
There was a problem hiding this comment.
What does rcProject stands for?
There was a problem hiding this comment.
This could probably be something like 'resolvedProject' instead - basically, .firebase rc has a map of alias -> project name, and this is using that map to resolve the user provided alias to a real project id
fredzqm
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a weird quirk of project selection behavior where we only respected the 'default' alias if there were no other aliases
Scenarios Tested
Ran a command with 2 aliases in my rc, and confirmed that it correctly used 'default'