Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secret version manager permissions to apphosting p4sa #7034

Merged
merged 12 commits into from
Apr 23, 2024
Merged

Add secret version manager permissions to apphosting p4sa #7034

merged 12 commits into from
Apr 23, 2024

Conversation

tonyjhuang
Copy link
Contributor

@tonyjhuang tonyjhuang commented Apr 22, 2024 •
edited
Loading

No description provided.

@tonyjhuang tonyjhuang requested a review from inlined April 22, 2024 23:01
inlined
inlined approved these changes Apr 23, 2024
View reviewed changes
src/api.ts Outdated Show resolved Hide resolved
inlined
inlined reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@inlined inlined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like unit tests need new oracles

@tonyjhuang tonyjhuang enabled auto-merge (squash) April 23, 2024 18:33
@tonyjhuang tonyjhuang merged commit aa90fa3 into master Apr 23, 2024
35 checks passed
@tonyjhuang tonyjhuang deleted the tonyjhuang/secret branch April 23, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inlined inlined inlined approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyjhuang @inlined