Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use default bucket api" #6418

Closed
wants to merge 3 commits into from
Closed

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Sep 28, 2023

Reverts #6406 - fixes #6416.

Turns out this API returns buckets in a different format than the old one.

Verified

This commit was signed with the committer’s verified signature.
richardlau Richard Lau
This reverts commit 77b3690.
@joehan joehan requested a review from kmcnellis September 28, 2023 22:07
@joehan joehan enabled auto-merge (squash) September 28, 2023 22:09
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6e9f56e) 54.73% compared to head (7486460) 54.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6418   +/-   ##
=======================================
  Coverage   54.73%   54.73%           
=======================================
  Files         346      346           
  Lines       23694    23692    -2     
  Branches     4872     4872           
=======================================
  Hits        12968    12968           
+ Misses       9533     9531    -2     
  Partials     1193     1193           
Files Coverage Δ
src/gcp/storage.ts 25.49% <40.00%> (+0.96%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joehan joehan closed this Sep 28, 2023
auto-merge was automatically disabled September 28, 2023 23:46

Pull request was closed

@joehan
Copy link
Contributor Author

joehan commented Sep 28, 2023

Turns out this was not the underlying issue - this was caused by a backend change which we are rolling out a fix for now

@lox
Copy link

lox commented Sep 29, 2023

Thanks for letting us know.

@lox
Copy link

lox commented Sep 29, 2023

Why is this not reflected in https://status.firebase.google.com/?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployments and emulators got broken: "Error: Invalid bucket name buckets/..."
4 participants