Add support for deploying new blocking triggers #6384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6384 +/- ##
==========================================
- Coverage 54.73% 54.60% -0.13%
==========================================
Files 346 346
Lines 23694 23870 +176
Branches 4872 4932 +60
==========================================
+ Hits 12968 13035 +67
- Misses 9533 9628 +95
- Partials 1193 1207 +14
☔ View full report in Codecov by Sentry. |
Xiaoshouzi-gh
approved these changes
Nov 9, 2023
| }; | ||
| } else { | ||
| throw new FirebaseError( | ||
| `Received invalid blocking trigger event type ${endpoint.blockingTrigger.eventType}` |
There was a problem hiding this comment.
quick question - seems like the error msg will be thrown to customers using firebase CLI, would new error codes and msg needs some sort of approval?
There was a problem hiding this comment.
The error message will be wrapped in an error object that will have a code related to a failed deployment.
Xiaoshouzi-gh
approved these changes
Aug 19, 2024
joehan
approved these changes
Aug 19, 2024
joehan
reviewed
Aug 19, 2024
|
Can you update this branch with a master rebase? @blidd-google |
* Blocking function SMS --------- Co-authored-by: Brian Li <[email protected]> Co-authored-by: joehan <[email protected]> Co-authored-by: Mathusan Selvarajah <[email protected]>
blidd-google
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCIP now supports two new event types
beforeSendEmailandbeforeSendSms. This PR adds support for deploying the new auth blocking function types that are triggered onbeforeSendEmailandbeforeSendSmsevents.