-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Included new info command #1230
base: master
Are you sure you want to change the base?
Conversation
@bkendall Thoughts 🤔 |
The CI test fails as I have used |
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
As this adds a new command, there's more internal process that has to happen as we (Firebase) are very deliberate about what we add to our public APIs, CLI commands included.
-
This seems like it accomplishes a very similar goal to our output when the
--debug
flag is turned on. As "run the command with the--debug
flag and provide the output" is a standard procedure for us while debugging, it may make more sense to include some of this information in that output instead. (And, as a bonus, if it's not adding a new command the friction to add this information output will be a lot lower.) What do you think?
3c43593
to
038601b
Compare
Did you read (2) in my previous comment? |
038601b
to
f198760
Compare
@bkendall IMO having a dedicated command to show up all those local environment information makes sense rather than including it with the |
Noted, thank you. That still doesn't change (1) from above - for a new command, we have to do further review. Do know that a lot of us are very busy with Google I/O related things, so it's unlikely anything changes this week. I can't say when an Thanks for your contribution, but it does take time to get all the pieces together when adding a new command... thanks for your patience. |
@bkendall I can understand 😃 |
prints debugging information about the environment
Linting fixes
f198760
to
1328918
Compare
Description
Included a new
info
command which shows debugging information about the environment which proves to be useful while submitting bug reports.Sample Commands
firebase info