Skip to content

Commit

Permalink
Misc nits.
Browse files Browse the repository at this point in the history
  • Loading branch information
taeold committed Jan 13, 2023
1 parent e779577 commit c81247a
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion src/deploy/functions/runtimes/node/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ export class Delegate {
// to decide whether to use the JS export method of discovery or the HTTP container contract
// method of discovery.
_sdkVersion: string | undefined = undefined;

get sdkVersion(): string {
if (this._sdkVersion === undefined) {
this._sdkVersion = versioning.getFunctionsSDKVersion(this.sourceDir) || "";
Expand Down
3 changes: 1 addition & 2 deletions src/emulator/functionsEmulator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ export class FunctionsEmulator implements EmulatorInstance {
logger.debug(`Building ${runtimeDelegate.name} source`);
await runtimeDelegate.build();

// Retrieve information from runtime delegate
// Retrieve information from the runtime delegate.
emulatableBackend.runtime = runtimeDelegate.runtime;
emulatableBackend.bin = runtimeDelegate.bin;

Expand Down Expand Up @@ -522,7 +522,6 @@ export class FunctionsEmulator implements EmulatorInstance {
);
return;
}

// Before loading any triggers we need to make sure there are no 'stale' workers
// in the pool that would cause us to run old code.
this.workerPools[emulatableBackend.codebase].refresh();
Expand Down
3 changes: 0 additions & 3 deletions src/extensions/emulator/optionsHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ import { needProjectId } from "../../projectUtils";
import { Emulators } from "../../emulator/types";
import { SecretEnvVar } from "../../deploy/functions/backend";

/**
*
*/
export async function buildOptions(options: any): Promise<any> {
const extDevDir = localHelper.findExtensionYaml(process.cwd());
options.extDevDir = extDevDir;
Expand Down

0 comments on commit c81247a

Please sign in to comment.