Skip to content

Commit

Permalink
Follow on fixes for #5892 (#5895)
Browse files Browse the repository at this point in the history
* Don't allow the devModeHandle if purpose is deploy
* `context._name` is gone?! Manually pass "purpose" rather than leaning poorly typed options
* Get more defensive w/types
* Rename purpose of "serve" to "emulate"
* Drop the Node 16 check, since v12 is 16+
* Purpose of "test" should default to production target
* Reject the devModeHost if process exits
* Replace old broken e2e test with the new frameworks test

Fixes #5896
  • Loading branch information
jamesdaniels authored May 25, 2023
1 parent e57b49a commit 51d2fd5
Show file tree
Hide file tree
Showing 26 changed files with 83 additions and 1,173 deletions.
1 change: 0 additions & 1 deletion .github/workflows/node-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ jobs:
- npm run test:storage-emulator-integration
- npm run test:triggers-end-to-end
- npm run test:triggers-end-to-end:inspect
- npm run test:webframeworks-deploy
steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Address additional cases where we were attempting to deploy a framework's development bundle (#5895)
5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"test:emulator": "bash ./scripts/emulator-tests/run.sh",
"test:extensions-deploy": "bash ./scripts/extensions-deploy-tests/run.sh",
"test:extensions-emulator": "bash ./scripts/extensions-emulator-tests/run.sh",
"test:frameworks": "bash ./scripts/frameworks-tests/run.sh",
"test:frameworks": "bash ./scripts/webframeworks-deploy-tests/run.sh",
"test:functions-deploy": "bash ./scripts/functions-deploy-tests/run.sh",
"test:functions-discover": "bash ./scripts/functions-discover-tests/run.sh",
"test:hosting": "bash ./scripts/hosting-tests/run.sh",
Expand All @@ -39,8 +39,7 @@
"test:triggers-end-to-end": "bash ./scripts/triggers-end-to-end-tests/run.sh",
"test:triggers-end-to-end:inspect": "bash ./scripts/triggers-end-to-end-tests/run.sh inspect",
"test:storage-deploy": "bash ./scripts/storage-deploy-tests/run.sh",
"test:storage-emulator-integration": "bash ./scripts/storage-emulator-integration/run.sh",
"test:webframeworks-deploy": "bash ./scripts/webframeworks-deploy-tests/run.sh"
"test:storage-emulator-integration": "bash ./scripts/storage-emulator-integration/run.sh"
},
"files": [
"lib",
Expand Down
32 changes: 0 additions & 32 deletions scripts/frameworks-tests/run.sh

This file was deleted.

24 changes: 0 additions & 24 deletions scripts/frameworks-tests/vite-project/.gitignore

This file was deleted.

9 changes: 0 additions & 9 deletions scripts/frameworks-tests/vite-project/counter.js

This file was deleted.

15 changes: 0 additions & 15 deletions scripts/frameworks-tests/vite-project/firebase.json

This file was deleted.

13 changes: 0 additions & 13 deletions scripts/frameworks-tests/vite-project/index.html

This file was deleted.

1 change: 0 additions & 1 deletion scripts/frameworks-tests/vite-project/javascript.svg

This file was deleted.

23 changes: 0 additions & 23 deletions scripts/frameworks-tests/vite-project/main.js

This file was deleted.

Loading

0 comments on commit 51d2fd5

Please sign in to comment.