Patch fix for issues caused by adding type check in #5906 (#6127)

firebase · Jul 19, 2023 · 1f5f2ac · 1f5f2ac
1 parent 83c5292
commit 1f5f2ac
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,3 +2,4 @@
 - Fixed bug where `firebase deploy --only firestore:named-db` didn't update rules. (#6129)
 - Fixed issue where Flutter Web is not detected as a web framework. (#6085)
 - Add better messages for API permissions failures that direct the user to the URL to enable the API. (#6130)
+- Fixes issue caused by adding type checks in #5906.
diff --git a/src/emulator/auth/operations.ts b/src/emulator/auth/operations.ts
@@ -198,13 +198,15 @@ async function signUp(
     }
   }
 
-  if (typeof reqBody.email === "string") {
+  // Assert a valid email address when we expect the email to have a value.
+  // Prevents empty email and password string to be treated as anonymous sign in.
+  if (reqBody.email || (reqBody.email === "" && provider)) {
     assert(isValidEmailAddress(reqBody.email), "INVALID_EMAIL");
     const email = canonicalizeEmailAddress(reqBody.email);
     assert(!state.getUserByEmail(email), "EMAIL_EXISTS");
     updates.email = email;
   }
-  if (typeof reqBody.password === "string") {
+  if (reqBody.password) {
     assert(
       reqBody.password.length >= PASSWORD_MIN_LENGTH,
       `WEAK_PASSWORD : Password should be at least ${PASSWORD_MIN_LENGTH} characters`