Remove modifiers from compat overloads #8604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 46986eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 49 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hsubox76
reviewed
Oct 25, 2024
There was a problem hiding this comment.
This should probably have a changeset for all -compat packages. Actually just noticed that the TS PR doesn't have a changeset. Can you add a patch changeset in this PR for all packages that says "Upgraded TypeScript to 5.5.4"? It'll affect the build artifact of every package, and they should all be rebuilt and published.
Size Report 1Affected ProductsNo changes between base commit (612335d) and merge commit (61ea077).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (612335d) and merge commit (61ea077).Test Logs |
Done |
hsubox76
approved these changes
Oct 25, 2024
dlarocque
force-pushed
the
dl/fix-compat-builds
branch
from
276349c
to
46986eb
Compare
Merged
ashish-kothari
added a commit
that referenced
this pull request
Nov 24, 2024
Squashed commit of the following: commit ffbf5a6 Author: Google Open Source Bot <[email protected]> Date: Thu Nov 14 07:04:30 2024 -0800 Version Packages (#8635) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> commit 2c27206 Merge: a75082f e3e2078 Author: Google Open Source Bot <[email protected]> Date: Tue Nov 12 07:48:12 2024 -0800 Merge main into release commit e3e2078 Author: Daniel La Rocque <[email protected]> Date: Wed Nov 6 09:57:57 2024 -0500 Consolidate CI test output into a single string (#8489) * Consolidate CI test output into a single string Having CI test process stdout and stderr in a single string makes it easier to read when looking through failures, since you can see the test output alongside the error messages. Without this, any stderr output written during a test will be captured seperately from the test output, so when we then log it after a test failure, we can't tell which test logged which errors. * Prefix stdout and stderr output commit 274e9a5 Author: Daniel La Rocque <[email protected]> Date: Tue Nov 5 17:25:54 2024 -0500 Remove unused `convertPropertiesForEnclosingClass" (#8618) commit caf3090 Author: Daniel La Rocque <[email protected]> Date: Wed Oct 30 15:12:32 2024 -0400 Upgrade ts-node to 10.19.2 (#8531) commit 0f5714b Author: Mark Duckworth <[email protected]> Date: Wed Oct 30 10:05:19 2024 -0600 Fix for 8474 - Prevent a possible condition of slow snapshots, caused by a rapid series of document update(s) followed by a delete. (#8595) commit d4cb3f8 Author: Daniel La Rocque <[email protected]> Date: Mon Oct 28 14:32:13 2024 -0400 Upgrade workflows Node version from `20.x` to `22.10.0` (#8601) Node 22 enters LTS on October 29th, 2024, so we should upgrade CI to run on Node 22. commit b807119 Author: Daniel La Rocque <[email protected]> Date: Fri Oct 25 15:16:08 2024 -0400 Remove modifiers from compat overloads (#8604) * Remove modifiers from compat overloads * format * Add changeset commit 612335d Author: Daniel La Rocque <[email protected]> Date: Fri Oct 25 14:31:32 2024 -0400 Upgrade webpack dependencies in e2e tests (#8605)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in the e2e tests where there are
declarestatements inside ofdeclareblocks: https://github.com/firebase/firebase-js-sdk/actions/runs/11518441707/job/32075789147In #8561, this script was modified, and all modifiers were accidentally added to all function declarations. This means that the
exportanddeclaremodifiers were brought over, which is what caused the issue.