Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FDL Deprecation & Hosting link Integration Test #8603

Merged
merged 3 commits into from
Oct 25, 2024
Merged

FDL Deprecation & Hosting link Integration Test #8603

merged 3 commits into from
Oct 25, 2024

Conversation

mansisampat
Copy link

Add Integration Tests for FDL Deprecation and Hosting Link.

Added the following tests -

  1. Allows user to sign in with default firebase hosting link
  2. Allows user to sign in to a tenant with default firebase hosting link
  3. Allows user to sign in with custom firebase hosting link
  4. Allows user to sign in to a tenant with custom firebase hosting link
  5. Sign in with invalid firebase hosting link throws exception

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 6c5d07d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v5.1

@mansisampat mansisampat merged commit 84b1006 into hosting-link Oct 25, 2024
19 of 21 checks passed
@mansisampat mansisampat deleted the hosting-link-it branch October 25, 2024 17:39
@NhienLam NhienLam self-requested a review October 25, 2024 17:41
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (85ebbce) and merge commit (0d2f262).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/m8n3373CJ1.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (85ebbce) and merge commit (0d2f262).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CJMNy7yY65.html

NhienLam
NhienLam reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@NhienLam NhienLam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run yarn run format in root directory.

packages/auth/test/integration/flows/hosting_link.test.ts Show resolved Hide resolved
@firebase firebase locked and limited conversation to collaborators Nov 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NhienLam NhienLam NhienLam left review comments

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mansisampat @google-oss-bot @NhienLam